xiangwangcheng commented on a change in pull request #1785:
DefaultMQProducerImpl#defaultAsyncSenderExecutor shutdown gracefully
URL: https://github.com/apache/rocketmq/pull/1785#discussion_r397724593
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
##########
@@ -253,8 +254,10 @@ public void shutdown(final boolean shutdownFactory) {
case CREATE_JUST:
break;
case RUNNING:
-
this.mQClientFactory.unregisterProducer(this.defaultMQProducer.getProducerGroup());
this.defaultAsyncSenderExecutor.shutdown();
+ ThreadUtils.shutdownGracefully(this.defaultAsyncSenderExecutor,
Review comment:
Why still invoke `this.defaultAsyncSenderExecutor.shutdown();` while you
already using `ThreadUtils.shutdownGracefully`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
