GongZhengMe commented on issue #242: Timeout param maybe influence the batch 
consumer Message result
URL: https://github.com/apache/rocketmq-spring/issues/242#issuecomment-604290650
 
 
   I pull a request https://github.com/apache/rocketmq-spring/pull/244,but  
coverage/coveralls doesn't let my method pass .
   because I copy the method :
   `syncSend(String destination, Collection<T> messages, long timeout) `
   the repetition rate is  too high.
   So I want to override `syncSend(String destination, Collection<T> messages, 
long timeout) `
   But now I have a problem about it. the timeout param's type is long.So I 
can't give long a default value:
   - null :long can't be determine null
   - 0: if I give 0 as default value ,the producer will have a timeout 
Exception.
   ps: 0 I don't write demo ,but I remember another method like scheduleMessage 
demo  if I set timeout as 0,the producer has exception.
   So I don't know how to override it.I think I can't alter the timeout param's 
type be Long.
   So I just copy the method `syncSend(String destination, Collection<T> 
messages, long timeout) ` for fix bug.
   But your code is strict in repetition rate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to