RongtongJin commented on a change in pull request #244: [issue #242]Fix Bug Of
BatchMessage SyncSend without timeout param
URL: https://github.com/apache/rocketmq-spring/pull/244#discussion_r398741151
##########
File path:
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/core/RocketMQTemplate.java
##########
@@ -466,6 +466,17 @@ public SendResult syncSend(String destination, Message<?>
message, long timeout)
return syncSend(destination, message, timeout, 0);
}
+ /**
+ * syncSend batch messages
+ *
+ * @param destination formats: `topicName:tags`
+ * @param messages Collection of {@link
org.springframework.messaging.Message}
+ * @return {@link SendResult}
+ */
+ public <T extends Message> SendResult syncSend(String destination,
Collection<T> messages) {
+ return syncSend(destination,messages,producer.getSendMsgTimeout());
Review comment:
It's just that the lack of spaces results in non-compliance with rocketmq
code style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
