imaffe edited a comment on pull request #557: URL: https://github.com/apache/rocketmq-externals/pull/557#issuecomment-618619445
Sorry I just found out that we shouldn't call `putConnectorConfig(connectorName, config);`, the `connectorKeyValueStore.put(connectorName, config);` did the desired job. This is because `putConnectorConfig()` will always try to load the new class and doesn't check if the connectorConfig has DELETED bit set to 1. And since `removeConnectorConfig()` and `putConnectorConfig()` are actually on the same level, which means they shouldn't call each other at all. However, the unused local variable still needs to be either deleted or needs some refactoring. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
