ShannonDing commented on a change in pull request #427:
URL: https://github.com/apache/rocketmq-client-go/pull/427#discussion_r416293484
##########
File path: internal/remote/tcp_conn.go
##########
@@ -40,6 +48,19 @@ func initConn(ctx context.Context, addr string)
(*tcpConnWrapper, error) {
}, nil
}
+// reference by net.ParseIP
+func isIPV4(s string) bool {
+ for i := 0; i < len(s); i++ {
+ switch s[i] {
+ case '.':
+ return true
Review comment:
OK, Got it.
The native branch has been moved to the master, you can submit this PR
directly to the master。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
