imaffe opened a new issue #564:
URL: https://github.com/apache/rocketmq-externals/issues/564


   In WorkerSourceTask.java line 184
   
   **BUG REPORT**
   
   ```
               ByteBuffer partition = sourceDataEntry.getSourcePartition();
               Optional<ByteBuffer> opartition = Optional.ofNullable(partition);
               ByteBuffer position = sourceDataEntry.getSourcePosition();
               Optional<ByteBuffer> oposition = Optional.ofNullable(partition);
   
   ```
   
   Seems  the the last line should be something like
   
   `Optional<ByteBuffer> oposition = Optional.ofNullable(position);` instead of 
partition. It's not detected because a lot of plugins are not using 
partition/position attributes. This should be easy to fix, but I'll probably 
create a bigger PR to fix a series of typos if we find any in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to