RongtongJin commented on a change in pull request #2059:
URL: https://github.com/apache/rocketmq/pull/2059#discussion_r433654655
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
##########
@@ -691,7 +691,7 @@ public void run() {
ProcessQueue processQueue =
assignedMessageQueue.getProcessQueue(messageQueue);
- if (processQueue == null && processQueue.isDropped()) {
+ if ((null == processQueue) || (processQueue != null &&
processQueue.isDropped())) {
Review comment:
why not just write as `if (processQueue == null ||
processQueue.isDropped())` ? This is more concise
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
