fantow commented on a change in pull request #2254:
URL: https://github.com/apache/rocketmq/pull/2254#discussion_r472770529
##########
File path:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
##########
@@ -381,7 +380,6 @@ protected RPCHook getRPCHook() {
* </p>
*/
public void scanResponseTable() {
- final List<ResponseFuture> rfList = new LinkedList<ResponseFuture>();
Review comment:
> Why do we remove the executeInvokeCallback() method here ? If it
timesout doesn't mean it should't execute InvokeCallback. Because timeout is
also a form of completion,.
I agree with your option.I will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
