liuruiyiyang commented on pull request #51: URL: https://github.com/apache/rocketmq-operator/pull/51#issuecomment-694714502
> > Thanks for your contribution~ > > There are several questions: > > > > 1. Design. Since the exporter is an independent service, would it be better to deploy in an independent pod and be optional? > > 2. Docker image. The image used by rocketmq-operator is better also open-sourced. So the dockerfile and other image related code should be added to our image package(dir) in general (or at least add some docs about how to build it). In that way we can build it, test it and push it to our official repository apacherocketmq. > > 3. Documentation. It is better to add some documents/related links about how to use it in full functioning. In fact there are dependencies like Prometheus and Grafana. > > Design： > > If the exporter is used as an independent pod, when I have multiple nameservers, my exporter does not know which nameserver to connect, so I use exporter as an option of nameserver, deploy it as a sidecar to nameserver。Can you give me some design advice? In fact operator maintains a variable in shared package named ```NameServersStr``` which is the ```NAMESRV_ADDR``` like: ```192.168.1.1:9876;192.168.1.2:9876```. You can use that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
