linjiemiao commented on a change in pull request #56:
URL: https://github.com/apache/rocketmq-operator/pull/56#discussion_r494074655
##########
File path: example/rocketmq_v1alpha1_broker_cr.yaml
##########
@@ -38,6 +38,8 @@ spec:
size: 1
# nameServers is the [ip:port] list of name service
nameServers: ""
+ # rocketMQName is the rocketmq name, must equal to
nameserver.spec.rocketMQName and topictransfer.spec.rocketMQName
Review comment:
I did this because we don't have a rocketmq resource as the parent
resource of the broker and nameserver. Without a common parent controller, we
can only specify the connection of the child resource in the spec. So I hope to
add a rocketmq api.
##########
File path: example/rocketmq_v1alpha1_broker_cr.yaml
##########
@@ -38,6 +38,8 @@ spec:
size: 1
# nameServers is the [ip:port] list of name service
nameServers: ""
+ # rocketMQName is the rocketmq name, must equal to
nameserver.spec.rocketMQName and topictransfer.spec.rocketMQName
Review comment:
I think so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
