vongosling commented on a change in pull request #2335:
URL: https://github.com/apache/rocketmq/pull/2335#discussion_r502384232
##########
File path:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -392,15 +392,15 @@ private PutMessageStatus checkStoreStatus() {
if (BrokerRole.SLAVE == this.messageStoreConfig.getBrokerRole()) {
long value = this.printTimes.getAndIncrement();
if ((value % 50000) == 0) {
- log.warn("message store has shutdown, so putMessage is
forbidden");
+ log.warn("broke role is slave, so putMessage is forbidden");
}
return PutMessageStatus.SERVICE_NOT_AVAILABLE;
}
if (!this.runningFlags.isWriteable()) {
long value = this.printTimes.getAndIncrement();
if ((value % 50000) == 0) {
- log.warn("message store has shutdown, so putMessage is
forbidden");
+ log.warn("message store could not write (may be disk full) so
putMessage is forbidden");
Review comment:
IMO, maybe is not a strict customer advice
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessor.java
##########
@@ -263,7 +263,7 @@ private void handlePutMessageResult(PutMessageResult
putMessageResult,
break;
case SERVICE_NOT_AVAILABLE:
log.info(
- "service not available now, maybe disk full, maybe your
broker machine memory too small.");
+ "service not available now, maybe disk full, maybe put
messages to slave, maybe message store shutdown, etc.");
Review comment:
Too many uncertain reasons can drive people crazy. You are advised to
change them to “you could check...” if not any diagnosis could be provided
furtherly.
##########
File path:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -392,15 +392,15 @@ private PutMessageStatus checkStoreStatus() {
if (BrokerRole.SLAVE == this.messageStoreConfig.getBrokerRole()) {
long value = this.printTimes.getAndIncrement();
if ((value % 50000) == 0) {
- log.warn("message store has shutdown, so putMessage is
forbidden");
+ log.warn("broke role is slave, so putMessage is forbidden");
}
return PutMessageStatus.SERVICE_NOT_AVAILABLE;
}
if (!this.runningFlags.isWriteable()) {
long value = this.printTimes.getAndIncrement();
if ((value % 50000) == 0) {
- log.warn("message store has shutdown, so putMessage is
forbidden");
+ log.warn("message store could not write (may be disk full) so
putMessage is forbidden");
Review comment:
IMO, maybe is not a strict customer advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
