RongtongJin commented on a change in pull request #32:
URL: https://github.com/apache/rocketmq-exporter/pull/32#discussion_r512395637
##########
File path: src/main/java/org/apache/rocketmq/exporter/config/RMQConfigure.java
##########
@@ -44,6 +44,16 @@
private volatile String rocketmqVersion =
System.getProperty(ROCKETMQ_CONFIG_ROCKETMQ_VERSION, "V4_3_2");
+ private String accessKey;
+
+ private String secretKey;
+
+ public boolean enableACL() {
+ return !(StringUtils.isAllBlank(this.accessKey)
+ &&
+ StringUtils.isAllBlank(this.secretKey));
+ }
+
Review comment:
I think it would be better to make it into a configurable switch for
enableACL rather than by whether AK/SK has a value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
