RongtongJin commented on a change in pull request #301:
URL: https://github.com/apache/rocketmq-spring/pull/301#discussion_r512639498



##########
File path: 
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/RocketMQUtil.java
##########
@@ -275,5 +276,13 @@ public static DefaultMQProducer 
createDefaultMQProducer(String groupName, String
 
         return producer;
     }
+    
+    public static String getInstanceName(String identify) {
+        String separator = "|";

Review comment:
       It would be better not to use "|", maybe use '@'.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to