[GitHub] [rocketmq-client-go] gaoyf opened a new issue #555: push_consumer not implement correctTagsOffset method

[GitBox]

gaoyf opened a new issue #555:
URL: https://github.com/apache/rocketmq-client-go/issues/555


   hi 
   1. 
[push_consumer](https://github.com/apache/rocketmq-client-go/blob/master/consumer/push_consumer.go#L717)
 没有实现correctTagsOffset方法导致在broker没有新消息时，通知客户端修改offset，但是客户端却未能更新。
   
参考java[代码](https://github.com/apache/rocketmq/blob/master/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L481)如下：
   ```
   private void correctTagsOffset(final PullRequest pullRequest) {
       if (0L == pullRequest.getProcessQueue().getMsgCount().get()) {
           this.offsetStore.updateOffset(pullRequest.getMessageQueue(), 
pullRequest.getNextOffset(), true);
       }
   }
   ```
   
   2. 另外[case 
primitive.PullNoNewMsg](https://github.com/apache/rocketmq-client-go/blob/master/consumer/push_consumer.go#L692)这种情况也需要调用correctTagsOffset方法。
   
   参考java的实现：
   
![image](https://user-images.githubusercontent.com/10137071/99226154-3ea70900-2824-11eb-93f8-abef323ca68f.png)
   
   请及时修复，谢谢
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org