shuyanzhu edited a comment on issue #337: URL: https://github.com/apache/rocketmq-client-cpp/issues/337#issuecomment-735337288
I mean all PulCalllbacks which were allocated in heap need to "delete this" in onSuccess or onException because there is no AutoDeletePullCallback to be inherited by user. SendCallback does has AutoDeleteSendCallback, but if there is exception occurs in send AutoDeleteSendCallback don't work, so user should catch exceptions and delete SendCallback mannually. I am confused why PullCallback doesn't has AutoDelete like SendCallback: > https://github.com/apache/rocketmq-client-cpp/blob/87350727950d1ece9ed3ffab414bbe0f673eeaac/include/AsyncCallback.h#L39 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
