lizhimins opened a new issue #656:
URL: https://github.com/apache/rocketmq-externals/issues/656
What is the purpose of the change
1. update RocketMQSource and RocketMQSink File for adapt new flink version
2. update flink connect rocketmq demo
3. support emit watermark in rocketmq source
Brief changelog
1. update RocketMQSource and RocketMQSink File for adapt new flink version
2. update flink connect rocketmq demo
3. support emit watermark in rocketmq source
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and
easily. Notice, it would be helpful if you could finish the following 5
checklist(the last one is not necessary)before request the community to review
your PR.
Make sure there is a Github issue filed for the change (usually before you
start working on it). Trivial changes like typos do not require a Github issue.
Your pull request should address just this issue, without pulling in other
changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when
host config not exist. Each commit in the pull request should have a meaningful
subject line and body.
Write a pull request description that is detailed enough to understand what
the pull request does, how, and why.
Write necessary unit-test(over 80% coverage) to verify your logic
correction, more mock a little better when cross module dependency exist. If
the new feature or significant change is committed, please remember to add
integration-test in test module.
Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Run mvn clean install -DskipITs to make sure
unit-test pass. Run mvn clean test-compile failsafe:integration-test to make
sure integration-test pass.
If this contribution is large, please file an Apache Individual Contributor
License Agreement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
