maixiaohai commented on a change in pull request #687:
URL: https://github.com/apache/rocketmq-externals/pull/687#discussion_r594969095
##########
File path:
rocketmq-iot-bridge/src/main/java/org/apache/rocketmq/iot/MQTTBridge.java
##########
@@ -38,36 +38,57 @@
import
org.apache.rocketmq.iot.protocol.mqtt.handler.downstream.impl.MqttDisconnectMessageHandler;
import
org.apache.rocketmq.iot.protocol.mqtt.handler.downstream.impl.MqttMessageForwarder;
import
org.apache.rocketmq.iot.protocol.mqtt.handler.downstream.impl.MqttPingreqMessageHandler;
+import
org.apache.rocketmq.iot.protocol.mqtt.handler.downstream.impl.MqttPublishMessageHandler;
import
org.apache.rocketmq.iot.protocol.mqtt.handler.downstream.impl.MqttSubscribeMessageHandler;
import
org.apache.rocketmq.iot.protocol.mqtt.handler.downstream.impl.MqttUnsubscribeMessagHandler;
+import org.apache.rocketmq.iot.storage.message.MessageStore;
+import org.apache.rocketmq.iot.storage.rocketmq.PublishProducer;
+import org.apache.rocketmq.iot.storage.rocketmq.RocketMQPublishProducer;
import org.apache.rocketmq.iot.storage.subscription.SubscriptionStore;
import
org.apache.rocketmq.iot.storage.subscription.impl.InMemorySubscriptionStore;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class MQTTBridge {
+ private Logger logger = LoggerFactory.getLogger(MQTTBridge.class);
+
+ private MqttBridgeConfig bridgeConfig;
private ServerBootstrap serverBootstrap;
private NioEventLoopGroup bossGroup;
private NioEventLoopGroup workerGroup;
+
private MessageDispatcher messageDispatcher;
private SubscriptionStore subscriptionStore;
private ClientManager clientManager;
private MqttConnectionHandler connectionHandler;
- private Logger logger = LoggerFactory.getLogger(MQTTBridge.class);
+ private MessageStore messageStore;
+ private PublishProducer publishProducer;
public MQTTBridge() {
init();
}
private void init() {
- bossGroup = new
NioEventLoopGroup(MQTTBridgeConfiguration.threadNumOfBossGroup());
- workerGroup = new
NioEventLoopGroup(MQTTBridgeConfiguration.threadNumOfWorkerGroup());
+ this.bridgeConfig = new MqttBridgeConfig();
+
+ subscriptionStore = new InMemorySubscriptionStore();
+ if (bridgeConfig.isEnableRocketMQStore()) {
+ this.publishProducer = new RocketMQPublishProducer(bridgeConfig);
Review comment:
The default store is rmq, but the old design stored in memory(simple
mode) could be keeped.
User could choose if turn on the rmq store, developer could use simple mode
to test basic feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
