lizhiboo commented on a change in pull request #2720:
URL: https://github.com/apache/rocketmq/pull/2720#discussion_r597639478
##########
File path:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyClientConfig.java
##########
@@ -20,23 +20,23 @@
/**
* Worker thread number
*/
- private int clientWorkerThreads = 4;
+ private int clientWorkerThreads = NettySystemConfig.clientWorkerSize;
private int clientCallbackExecutorThreads =
Runtime.getRuntime().availableProcessors();
private int clientOnewaySemaphoreValue =
NettySystemConfig.CLIENT_ONEWAY_SEMAPHORE_VALUE;
private int clientAsyncSemaphoreValue =
NettySystemConfig.CLIENT_ASYNC_SEMAPHORE_VALUE;
- private int connectTimeoutMillis = 3000;
+ private int connectTimeoutMillis = NettySystemConfig.connectTimeoutMillis;
private long channelNotActiveInterval = 1000 * 60;
Review comment:
Is this param should be parameterized？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
