areyouok commented on a change in pull request #2832:
URL: https://github.com/apache/rocketmq/pull/2832#discussion_r619169901
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/AssignedMessageQueue.java
##########
@@ -83,10 +83,15 @@ public long getPullOffset(MessageQueue messageQueue) {
return -1;
}
- public void updatePullOffset(MessageQueue messageQueue, long offset) {
+ public void updatePullOffset(MessageQueue messageQueue, long offset,
ProcessQueue processQueue) {
MessageQueueState messageQueueState =
assignedMessageQueueState.get(messageQueue);
- if (messageQueueState != null) {
- messageQueueState.setPullOffset(offset);
+ synchronized (this.assignedMessageQueueState) {
+ if (messageQueueState.getProcessQueue() != processQueue) {
+ return;
+ }
+ if (messageQueueState != null) {
+ messageQueueState.setPullOffset(offset);
+ }
}
Review comment:
It seems the synchronized lock can be removed.
I have update this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
