ayanamist opened a new pull request #2917: URL: https://github.com/apache/rocketmq/pull/2917
**Make sure set the target branch to `develop`** ## What is the purpose of the change Improve unit test stability ## Brief changelog 1. `org.apache.rocketmq.client.trace.DefaultMQConsumerWithOpenTracingTest#testPullMessage_WithTrace_Success` has a race condition that when countDownLatch in callback executed, `countDownLatch.await` will pass, but `finishSpan` is not surely executed because it executed after callback, so `tracer.finishedSpans` will not have data if `finishSpan` is executed a little late after `countDownLatch.await`, and test will fail. Since there is no sutable assert point to make sure that `finishSpan` is executed, i add a `waitAtMost` to retry this assert for one second. 2. The init methods of `DefaultMQPushConsumerTest` & `DefaultMQConsumerWithOpenTracingTest` mock something after `consumer.start`, but `consumer.start` creates and starts some thread pool to execute, and the ThreadLocal mechanism of mockito will mess with them which creates a race condition, so mock method won't be effective sometimes. I refactor those codes to make mock before `consumer.start` to avoid those race conditions. ## Verifying this change XXXX Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
