caigy commented on a change in pull request #2999:
URL: https://github.com/apache/rocketmq/pull/2999#discussion_r664337665
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
##########
@@ -750,7 +745,7 @@ private SendResult sendKernelImpl(final Message msg,
}
final String tranMsg =
msg.getProperty(MessageConst.PROPERTY_TRANSACTION_PREPARED);
- if (tranMsg != null && Boolean.parseBoolean(tranMsg)) {
+ if (Boolean.parseBoolean(tranMsg)) {
Review comment:
`tranMsg != null` can be viewed as double check here although
`Boolean.parseBoolean` will check it, so it seems that removing this null check
won't gain much profit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
