caigy commented on a change in pull request #3176:
URL: https://github.com/apache/rocketmq/pull/3176#discussion_r677158535
##########
File path:
acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java
##########
@@ -130,6 +130,7 @@ public boolean updateAccessConfig(PlainAccessConfig
plainAccessConfig) {
log.error("Parameter value plainAccessConfig is null,Please check
your parameter");
throw new AclException("Parameter value plainAccessConfig is null,
Please check your parameter");
}
+ buildPlainAccessResource(plainAccessConfig); // check config
Review comment:
It seems that only null checks is necessary here, extracting a check
method to accomplish it may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
