areyouok commented on a change in pull request #3195:
URL: https://github.com/apache/rocketmq/pull/3195#discussion_r683080211
##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -802,8 +802,8 @@ private String generateKey(StringBuilder keyBuilder,
MessageExt messageExt) {
PutMessageResult putMessageResult = new
PutMessageResult(PutMessageStatus.PUT_OK, result);
// Statistics
-
storeStatsService.getSinglePutMessageTopicTimesTotal(messageExtBatch.getTopic()).addAndGet(result.getMsgNum());
-
storeStatsService.getSinglePutMessageTopicSizeTotal(messageExtBatch.getTopic()).addAndGet(result.getWroteBytes());
+
storeStatsService.getSinglePutMessageTopicTimesTotal(messageExtBatch.getTopic()).add(1);
Review comment:
save a method invocation
##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -802,8 +802,8 @@ private String generateKey(StringBuilder keyBuilder,
MessageExt messageExt) {
PutMessageResult putMessageResult = new
PutMessageResult(PutMessageStatus.PUT_OK, result);
// Statistics
-
storeStatsService.getSinglePutMessageTopicTimesTotal(messageExtBatch.getTopic()).addAndGet(result.getMsgNum());
-
storeStatsService.getSinglePutMessageTopicSizeTotal(messageExtBatch.getTopic()).addAndGet(result.getWroteBytes());
+
storeStatsService.getSinglePutMessageTopicTimesTotal(messageExtBatch.getTopic()).add(1);
Review comment:
Your are right, i will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
