schnell18 edited a comment on issue #3257:
URL: https://github.com/apache/rocketmq/issues/3257#issuecomment-898884407


   Thank you very much for quick reponse. We had this problem on a 4.6.0 
production environment and I also reproduced this problem on 4.8.0. It seems to 
me this issue applies to code on master branch as well.
   
   We lost quite a few data and spent days to recover due to this problem. The 
failure to start the broker w/ empty files under commit log directory surprised 
and confused us quite a lot. And we didn't see same problem on brokers in the 
same cluster and it WORKED previously. Then our admin created an empty commit 
log directory and made the broker use that. The broker started successfully at 
last. However, almost all our application topics were lost. It took us a few 
days to recover messy data caused by this accident. 
   
   RocketMQ is quite reliable and it is definitely unlikely to corrupt the 
commit log by itself. 
   And commit log file names are 20-digit w/ zero padding. There is no reason 
to make big fuss about irrelevant files, the 
'the-bad-empty-file-fails-rocketmq-startup' in this case, and fails the 
startup. It makes perfect sense to igore files does not match the commit log 
name pattern and only fail on real commit log corruption.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to