ni-ze commented on a change in pull request #779:
URL: https://github.com/apache/rocketmq-externals/pull/779#discussion_r690837199
##########
File path: rocketmq-flink/pom.xml
##########
@@ -34,7 +34,7 @@
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<rocketmq.version>4.7.1</rocketmq.version>
- <flink.version>1.13.0</flink.version>
+ <flink.version>1.13.1</flink.version>
Review comment:
Why rocketmq-flink package has flink jar?That will lead a package
conflict when run on Flink.
It should set scope to "provided".
```xml
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-java</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
