pirateskipper commented on a change in pull request #3228:
URL: https://github.com/apache/rocketmq/pull/3228#discussion_r693677468
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
##########
@@ -1182,7 +1186,29 @@ public TopicStatsTable getTopicStatsInfo(final String
addr, final String topic,
request, timeoutMillis);
switch (response.getCode()) {
case ResponseCode.SUCCESS: {
- TopicStatsTable topicStatsTable =
TopicStatsTable.decode(response.getBody(), TopicStatsTable.class);
+ TopicStatsTable topicStatsTable =
TopicStatsTable.decode(response.getBody(), new
TypeReference<TopicStatsTable<TopicOffset>>(){});
+ return topicStatsTable;
+ }
+ default:
+ break;
Review comment:
` throw new MQBrokerException(response.getCode(), response.getRemark(),
addr);
}
`
##########
File path:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -910,6 +910,16 @@ public long getMessageTotalInQueue(String topic, int
queueId) {
return -1;
}
+ @Override
+ public long getMessageTotalSizeInQueue(String topic, int queueId) {
+ ConsumeQueue logicQueue = this.findConsumeQueue(topic, queueId);
+ if (logicQueue != null) {
Review comment:
`return logicQueue == null ? -1 :
logicQueue.getMessageSizeTotalInQueue();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
