ltamber commented on a change in pull request #3287:
URL: https://github.com/apache/rocketmq/pull/3287#discussion_r700134830



##########
File path: 
store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
##########
@@ -113,7 +115,7 @@ public long computeDeliverTimestamp(final int delayLevel, 
final long storeTimest
     public void start() {
         if (started.compareAndSet(false, true)) {
             super.load();
-            this.timer = new Timer("ScheduleMessageTimerThread", true);
+            this.scheduledExecutorService = new 
ScheduledThreadPoolExecutor(32, new 
DefaultThreadFactory("ScheduleMessageTimerThread"));

Review comment:
       IMO, it would be better if the thread pool core size is configureable or 
just use `Runtime.getRuntime().availableProcessors()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to