leikang123 commented on pull request #3343:
URL: https://github.com/apache/rocketmq/pull/3343#issuecomment-917406347
Oh, I see. Which layers of code are more complex, or indicate what I can
contribute. Thank you!
发自我的iPhone
------------------ Original ------------------
From: rongtong ***@***.***>
Date: Sat,Sep 11,2021 9:11 PM
To: apache/rocketmq ***@***.***>
Cc: leikang123 ***@***.***>, Mention ***@***.***>
Subject: Re: [apache/rocketmq] Add comments to the two enumeration codes
store/config/BrokerRole.java and FlushDiskType.java (#3343)
@RongtongJin commented on this pull request.
Hi, @leikang123 Welcome to contribute code to the rocketmq community. IMO,
a lot of comments are unnecessary and redundant for these three files in this
pull request, FlushDiskType and BrokeRole don't need extra attention, comments
should be a concise explanation of complex code. Hope you can submit a more
meaningful pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
