zhangjidi2016 commented on a change in pull request #21:
URL: https://github.com/apache/rocketmq-dashboard/pull/21#discussion_r708874722
##########
File path:
src/main/java/org/apache/rocketmq/dashboard/service/impl/TopicServiceImpl.java
##########
@@ -61,16 +61,28 @@
private RMQConfigure configure;
@Override
- public TopicList fetchAllTopicList(boolean skipSysProcess) {
+ public TopicList fetchAllTopicList(boolean skipSysProcess, boolean
skipRetryAndDlq) {
try {
TopicList allTopics = mqAdminExt.fetchAllTopicList();
if (skipSysProcess) {
return allTopics;
}
- TopicList sysTopics = getSystemTopicList();
Set<String> topics = new HashSet<>();
+ if (skipRetryAndDlq) {
Review comment:
Yes, need to take into account the fact that both skipSysProcess and
skipRetryAndDlq are true，I will optimize this method using stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
