areyouok commented on a change in pull request #3039:
URL: https://github.com/apache/rocketmq/pull/3039#discussion_r710065805
##########
File path:
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##########
@@ -222,8 +222,9 @@ public SubscriptionGroupConfig
examineSubscriptionGroupConfig(String addr, Strin
}
@Override
- public TopicConfig examineTopicConfig(String addr, String topic) {
- return null;
+ public TopicConfig examineTopicConfig(String addr, String topic) throws
RemotingException, InterruptedException, MQBrokerException {
+ TopicConfigSerializeWrapper topicConfigSerializeWrapper =
this.mqClientInstance.getMQClientAPIImpl().getAllTopicConfig(addr,timeoutMillis);
+ return topicConfigSerializeWrapper.getTopicConfigTable().get(topic);
Review comment:
check topicConfigSerializeWrapper.getTopicConfigTable().get(topic) is
null and throw Exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
