francisoliverlee commented on pull request #3357:
URL: https://github.com/apache/rocketmq/pull/3357#issuecomment-924529808


   > > > DiskCheckScheduledThread1
   > > 
   > > 
   > > @francisoliverlee Thank you for the notice.
   > > Error in `DiskCheckScheduledThread1` is due to storePathCommitLog usage 
in "DefaultMessageStore.CleanCommitLogService#isSpaceFull". I fixed it and 
added test in last commit.
   > > Sorry for missing that. I have checked all the usage of 
`storePathCommitLog`.
   > 
   > It seems this error still exists ,and maybe you discarded this method 
_org.apache.rocketmq.common.UtilAll#getDiskPartitionSpaceUsedPercent_, or 
should we check the existence of a directory at the start of the broker?
   
   when doing getDiskPartitionSpaceUsedPercent(),  how about a WARNING for NO 
consume queue dir ?
   @Jason918 @duhenglucky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to