lizhanhui commented on a change in pull request #1:
URL: https://github.com/apache/rocketmq-apis/pull/1#discussion_r720610289
##########
File path: apache/rocketmq/v1/definition.proto
##########
@@ -0,0 +1,311 @@
+syntax = "proto3";
+
+import "google/protobuf/timestamp.proto";
+import "google/protobuf/duration.proto";
+
+package apache.rocketmq.v1;
+
+option java_multiple_files = true;
+option java_package = "apache.rocketmq.v1";
+option java_generate_equals_and_hash = true;
+option java_string_check_utf8 = true;
+
+// Ali Cloud Service
+option java_outer_classname = "MQDomain";
+
+enum Permission {
+ NONE = 0;
+ READ = 1;
+ WRITE = 2;
+ READ_WRITE = 3;
+
+ reserved 4 to 64;
+}
+
+enum FilterType {
+ TAG = 0;
+ SQL = 1;
+
+ reserved 2 to 64;
+}
+
+message FilterExpression {
+ FilterType type = 1;
+ string expression = 2;
+
+ reserved 3 to 64;
+}
+
+// Dead lettering is done on a best effort basis. The same message might be
+// dead lettered multiple times.
+//
+// If validation on any of the fields fails at subscription creation/update,
+// the create/update subscription request will fail.
+message DeadLetterPolicy {
+ // The maximum number of delivery attempts for any message.
+ //
+ // This field will be honored on a best effort basis.
+ //
+ // If this parameter is 0, a default value of 5 is used.
Review comment:
The default value here is incorrect. Default max attempt is 16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
