lizhanhui commented on a change in pull request #3386:
URL: https://github.com/apache/rocketmq/pull/3386#discussion_r720615560
##########
File path:
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java
##########
@@ -17,11 +17,17 @@
package org.apache.rocketmq.remoting.protocol;
import com.alibaba.fastjson.JSON;
+import com.alibaba.fastjson.serializer.SerializerFeature;
+
import java.nio.charset.Charset;
public abstract class RemotingSerializable {
private final static Charset CHARSET_UTF8 = Charset.forName("UTF-8");
+ static {
Review comment:
Before modifying the behavior, we have to:
1, Make sure code can correctly deserialize JSON strings previously
serialized without Compatible Feature configured;
2, Make sure clients without feature configured may compatibly parse
standard JSON;
3, Verify JSON generated with feature configured can serialize and
deserialize complex objects, say a map with non-string key.
Once these three compatible concerns are resolved, I am glad to +1 for this
pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
