lizhanhui commented on a change in pull request #5:
URL: https://github.com/apache/rocketmq-apis/pull/5#discussion_r725438852
##########
File path: apache/rocketmq/v1/service.proto
##########
@@ -264,74 +264,71 @@ message PullMessageResponse {
reserved 6 to 64;
}
-message GenericPollingRequest {
- string client_id = 1;
- repeated Resource topics = 2;
- oneof group {
- Resource producer_group = 3;
- Resource consumer_group = 4;
- }
-
- reserved 5 to 64;
+message NoopCommand {
+ reserved 1 to 64;
}
-message GenericPollingResponse {
- ResponseCommon common = 1;
+message PrintThreadStackTraceCommand {
+ string task_id = 1;
Review comment:
command_id looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
