shendongsd commented on a change in pull request #3399:
URL: https://github.com/apache/rocketmq/pull/3399#discussion_r725631327
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
##########
@@ -622,14 +622,7 @@ private SendResult sendDefaultImpl(
default:
break;
}
- } catch (RemotingException e) {
- endTimestamp = System.currentTimeMillis();
- this.updateFaultItem(mq.getBrokerName(), endTimestamp
- beginTimestampPrev, true);
- log.warn(String.format("sendKernelImpl exception,
resend at once, InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp -
beginTimestampPrev, mq), e);
- log.warn(msg.toString());
- exception = e;
- continue;
- } catch (MQClientException e) {
+ } catch (RemotingException | MQClientException e) {
Review comment:
The parameter passing of the updateFaultItem method of
InterruptedException is different from the other two exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
