fangzhiheng opened a new pull request #3514:
URL: https://github.com/apache/rocketmq/pull/3514
**Make sure set the target branch to `develop`**
## What is the purpose of the change
由于RemotingSerializable's 的一些子类有类似于 Map<Object, Object>
这样的属性，它们由fastjson序列化后，其JSON的key也是一个object，而这个大多数语言的JSON库无法支持反序列化（比如JS、Golang），因此在开发客户端的时候会造成额外的工作量，故增加SerializerFeature#WriteNonStringKeyAsString的序列化特性，以支持其他语言客户端开发。
## Brief changelog
```java
// org.apache.rocketmq.remoting.protocol.RemotingSerializable：
public static String toJson(final Object obj, boolean prettyFormat) {
return JSON.toJSONString(obj, JSON.DEFAULT_GENERATE_FEATURE |
SerializerFeature.WriteNonStringKeyAsString.mask |
(prettyFormat ? SerializerFeature.PrettyFormat.mask : 0));
}
```
## Verifying this change
```java
// org.apache.rocketmq.remoting.protocol.RemotingSerializableTest
@Test
public void testMapSample() {
Map<Sample, Sample> map = new HashMap<>();
Sample sample = new Sample();
map.put(sample, sample);
MapSample ms = new MapSample();
ms.setMapping(map);
String json = RemotingSerializable.toJson(ms, false);
MapSample decoded = RemotingSerializable.decode(json.getBytes(),
MapSample.class);
assertThat(decoded).isEqualTo(ms);
assertThat(decoded.getMapping()).isEqualTo(ms.getMapping());
}
```
Follow this checklist to help us incorporate your contribution quickly and
easily. Notice, `it would be helpful if you could finish the following 5
checklist(the last one is not necessary)before request the community to review
your PR`.
- [x] Make sure there is a [Github
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic
correction, more mock a little better when cross module dependency exist. If
the new feature or significant change is committed, please remember to add
integration-test in [test
module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
