panzhi33 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992451468


   > > @haozhijie9527 @areyouok Please help to check again
   > 
   > The synchronized block in RequestFutureHolder is not safe enough. 
Concurrent problem still exists.
   > 
   > I sugguest move DefaultMQProducerImpl.startScheduledTask() and
   > 
   > ```
   >                 if 
(RequestFutureHolder.getInstance().getProducerNum().decrementAndGet() == 0) {
   >                     
RequestFutureHolder.getInstance().getScheduledExecutorService().shutdown();
   >                 }
   > ```
   > 
   > to RequestFutureHolder.
   
   OK, it’s been revised, please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to