xijiu commented on a change in pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#discussion_r775243608



##########
File path: 
tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java
##########
@@ -99,4 +69,30 @@ public void testExecute() throws SubCommandException {
             ServerUtil.parseCmdLine("mqadmin " + cmd.commandName(), subargs, 
cmd.buildCommandlineOptions(options), new PosixParser());
         cmd.execute(commandLine, options, null);
     }
+
+    private ServerResponseMocker startNameServer() {

Review comment:
       When coding, I also realized that the code repetition of 
startNameServer() is relatively high. I wanted to retain the flexibility of 
this method.
   
   However, in most scenarios, startNameServer() can indeed use the default 
configuration. I will extract a NameServer of the default type, If other test 
cases have specific requirements, rewrite their own logic 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to