StyleTang commented on a change in pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69#discussion_r785317576
##########
File path:
src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -83,8 +82,7 @@ public void run() {
outTPS += bsd.getStatsMinute().getTps();
outMsgCntToday +=
StatsAllSubCommand.compute24HourSum(bsd);
} catch (Exception e) {
- log.warn("Exception caught: mqAdminExt get
broker stats data GROUP_GET_NUMS failed");
- log.warn("Response [{}] ", e.getMessage());
+ log.warn("Exception caught: mqAdminExt get
broker stats data GROUP_GET_NUMS failed", e.getMessage());
Review comment:
[Trivial] Usually log exception stack instead of not only exception
message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
