odbozhou commented on a change in pull request #3232:
URL: https://github.com/apache/rocketmq/pull/3232#discussion_r787377174
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##########
@@ -267,9 +268,16 @@ private synchronized RemotingCommand
updateAndCreateTopic(ChannelHandlerContext
topicConfig.setTopicFilterType(requestHeader.getTopicFilterTypeEnum());
topicConfig.setPerm(requestHeader.getPerm());
topicConfig.setTopicSysFlag(requestHeader.getTopicSysFlag() == null ?
0 : requestHeader.getTopicSysFlag());
+ topicConfig.setExpirationTime(requestHeader.getExpireTime());
Review comment:
Should topic expireTime limit the maximum time? If expireTime is greater
than the maximum time for commitlog storage, expireTime is meaningless?
##########
File path: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
##########
@@ -330,6 +336,17 @@ public boolean flush(final int flushLeastPages) {
return result;
}
+ public int deleteExpiredFile(
Review comment:
Does the expired topic only delete the consumeQueue, and the commitLog
still exists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
