ni-ze commented on a change in pull request #3659:
URL: https://github.com/apache/rocketmq/pull/3659#discussion_r772796555
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java
##########
@@ -109,11 +109,48 @@ private void checkHoldRequest() {
}
}
+ @Override
+ protected void onWaitEnd() {
+ final int batch = 1000;
+ for (int i = 0; i < batch; i++) {
+ Runnable runnable = notifyList.poll();
+ if (runnable != null) {
+ runnable.run();
Review comment:
if runnable.run() throw throwable, the checkHoldRequest method in the
below will not invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
