dongeforever commented on a change in pull request #3807:
URL: https://github.com/apache/rocketmq/pull/3807#discussion_r794465818
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
##########
@@ -588,6 +603,27 @@ private RemotingCommand
handlePutMessageResult(PutMessageResult putMessageResult
return CompletableFuture.completedFuture(response);
}
+ String[] topics = null;
+ int[] queueIds = null;
+ if (requestHeader.isMultiTopic()) {
+ topics =
requestHeader.getTopic().split(MixAll.BATCH_TOPIC_SPLITTER); // decode topics
+ if (requestHeader.getQueueIds() == null) {
Review comment:
For reference only.
How about providing a common BATCH API style?
Encode/Decode the header and body in batch mode, and reuse the
processor/storage layer.
It is better not to introduce the batch difficulty to the storage layer.
For advanced feature batch consumequeue, it is not able to handle the inner
message num, if the body has multi topic-queues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
