ni-ze commented on a change in pull request #3838:
URL: https://github.com/apache/rocketmq/pull/3838#discussion_r805139525
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
##########
@@ -645,21 +645,39 @@ private void removePullTask(final String topic) {
}
public synchronized void commitAll() {
- try {
- for (MessageQueue messageQueue :
assignedMessageQueue.messageQueues()) {
- long consumerOffset =
assignedMessageQueue.getConsumerOffset(messageQueue);
- if (consumerOffset != -1) {
- ProcessQueue processQueue =
assignedMessageQueue.getProcessQueue(messageQueue);
- if (processQueue != null && !processQueue.isDropped()) {
- updateConsumeOffset(messageQueue, consumerOffset);
- }
- }
+ for (MessageQueue messageQueue : assignedMessageQueue.messageQueues())
{
Review comment:
I do not think this is necessary, we do not need persist offset for
BROADCASTING separately, timed task can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
