Erik1288 commented on pull request #3848: URL: https://github.com/apache/rocketmq/pull/3848#issuecomment-1041033566
Thanks for your comments. > More suggested comments: > > 1. Add some comments for interface Swappable, it's difficult to understand the specific meaning of `swapMap` and `cleanSwappedMap` directly. Re: Sure, more meaningful comments will be added. > 2. Add unit tests for this PR, and the implementations of `Swappable`. Re: Unit-test and Implementation were pushed but not be called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
