XiaoyiPeng opened a new issue #3924:
URL: https://github.com/apache/rocketmq/issues/3924


   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   
![image](https://user-images.githubusercontent.com/8653312/156546032-c82ac422-ef1f-43e4-b5e3-2d6a550e8448.png)
   
   - The method `StoreStatsService#initPutMessageDistributeTime()`  is only 
called in the constructor and method `StoreStatsService#printTps()`(which is 
**private**),  it may be better to change it to **private**.
   
       And the method `StoreStatsService#initPutMessageTimeBuckets()` also like 
this.
   
   - The method `StoreStatsService#initPutMessageDistributeTime()` is repeated 
called by method `printTps() ` periodically,
     it's internal logic is to reset the current data structure(eg:  
`StoreStatsService#putMessageDistributeTime`) for new data. 
   I think it would be more appropriate for the method name to start with 
**reset** instead of **init**.
   
   
   2. Please tell us about your environment:
   
     - OS: Windows10
   
     -    branch: develop 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to