zhaohai1299002788 commented on a change in pull request #2:
URL: https://github.com/apache/rocketmq-connect/pull/2#discussion_r821388948
##########
File path:
connectors/aliyun/rocketmq-connect-dingtalk/src/main/java/com/aliyun/rocketmq/connect/dingtalk/sink/DingTalkSinkConnector.java
##########
@@ -0,0 +1,61 @@
+package com.aliyun.rocketmq.connect.dingtalk.sink;
+
+import com.aliyun.rocketmq.connect.dingtalk.sink.constant.DingTalkConstant;
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.Task;
+import io.openmessaging.connector.api.component.task.sink.SinkConnector;
+import io.openmessaging.internal.DefaultKeyValue;
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class DingTalkSinkConnector extends SinkConnector {
+
+ private String webHook;
+
+ private String msgType;
+
+ @Override
+ public void pause() {
+
+ }
+
+ @Override
+ public void resume() {
+
+ }
+
+ @Override
+ public List<KeyValue> taskConfigs(int maxTasks) {
+ List<KeyValue> taskConfigList = new ArrayList<>(11);
+ KeyValue keyValue = new DefaultKeyValue();
+ keyValue.put(DingTalkConstant.WEB_HOOK, webHook);
+ keyValue.put(DingTalkConstant.MSG_TYPE_CONSTANT, msgType);
+ taskConfigList.add(keyValue);
Review comment:
delete duplicate code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
