ferrirW opened a new pull request #25:
URL: https://github.com/apache/rocketmq-mqtt/pull/25
link #19
some code can be optimized:
1. ADDFLAG & JINFLAG should be replaced with PLUS_SIGN & NUMBER_SIGN refer
to unicode
2. Some redundant containsKey before putIfAbsent()
3. buildIntanceName -> buildInstanceName
4. TopicUtils.isMatch("t/t1/t2/", "t/#/t2/") should be false but return true
now.(I know some client will do this check like poho, however, it is better for
the server to do a validation as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
