Git-Yang commented on a change in pull request #3941:
URL: https://github.com/apache/rocketmq/pull/3941#discussion_r825907023
##########
File path:
client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueByConfig.java
##########
@@ -16,16 +16,20 @@
*/
package org.apache.rocketmq.client.consumer.rebalance;
+import java.util.ArrayList;
import java.util.List;
-import org.apache.rocketmq.client.consumer.AllocateMessageQueueStrategy;
import org.apache.rocketmq.common.message.MessageQueue;
-public class AllocateMessageQueueByConfig implements
AllocateMessageQueueStrategy {
+public class AllocateMessageQueueByConfig extends
AbstractAllocateMessageQueueStrategy {
private List<MessageQueue> messageQueueList;
@Override
public List<MessageQueue> allocate(String consumerGroup, String
currentCID, List<MessageQueue> mqAll,
List<String> cidAll) {
+ List<MessageQueue> result = new ArrayList<MessageQueue>();
+ if (!check(consumerGroup, currentCID, mqAll, cidAll)) {
Review comment:
There seems to be no need for verification here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
