caigy commented on a change in pull request #4010:
URL: https://github.com/apache/rocketmq/pull/4010#discussion_r831715983
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessor.java
##########
@@ -157,8 +158,10 @@ private PushReplyResult pushReplyMessage(final
ChannelHandlerContext ctx,
final SendMessageRequestHeader requestHeader,
final Message msg) {
ReplyMessageRequestHeader replyMessageRequestHeader = new
ReplyMessageRequestHeader();
-
replyMessageRequestHeader.setBornHost(ctx.channel().remoteAddress().toString());
- replyMessageRequestHeader.setStoreHost(this.getStoreHost().toString());
+ InetSocketAddress bornAddress
=(InetSocketAddress)(ctx.channel().remoteAddress());
+ replyMessageRequestHeader.setBornHost(bornAddress.getHostName() + ":"
+ bornAddress.getPort());
Review comment:
Can we use `getHostString()` here to skip reverse lookup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
