caigy commented on a change in pull request #61:
URL: https://github.com/apache/rocketmq-operator/pull/61#discussion_r834277621
##########
File path: pkg/apis/rocketmq/v1alpha1/nameservice_types.go
##########
@@ -49,6 +49,20 @@ type NameServiceSpec struct {
HostPath string `json:"hostPath"`
// VolumeClaimTemplates defines the StorageClass
VolumeClaimTemplates []corev1.PersistentVolumeClaim
`json:"volumeClaimTemplates"`
+ // Affinity, affinity and anti-affinity scheduling
+ Affinity *corev1.Affinity `json:"affinity,omitempty"`
+ // SecurityContext defines privilege and access control settings for a
Pod or Container.
+ SecurityContext *corev1.PodSecurityContext
`json:"securityContext,omitempty"`
+ // ImagePullSecrets pull an image from a private registry
+ ImagePullSecrets []corev1.LocalObjectReference
`json:"imagePullSecrets,omitempty"`
+ // Tolerations taints and tolerations work together to ensure that pods
are not scheduled onto inappropriate nodes
+ Tolerations []corev1.Toleration
`json:"tolerations,omitempty"`
+ // NodeSelector is the simplest recommended form of node selection
constraint.
+ NodeSelector map[string]string
`json:"nodeSelector,omitempty"`
+ // PodAnnotations you can use annotations to attach arbitrary
non-identifying metadata to objects.
+ PodAnnotations map[string]string
`json:"podAnnotations,omitempty"`
+ // PriorityClassName defines priority class's name
+ PriorityClassName string
`json:"priorityClassName,omitempty"`
Review comment:
It seems null checks are required for them, would define them as pointer
be better?
##########
File path: pkg/apis/rocketmq/v1alpha1/broker_types.go
##########
@@ -56,6 +56,21 @@ type BrokerSpec struct {
VolumeClaimTemplates []corev1.PersistentVolumeClaim
`json:"volumeClaimTemplates"`
// The name of pod where the metadata from
ScalePodName string `json:"scalePodName"`
+ // Affinity, affinity and anti-affinity scheduling
+ Affinity *corev1.Affinity `json:"affinity,omitempty"`
+ // SecurityContext defines privilege and access control settings for a
Pod or Container.
+ SecurityContext *corev1.PodSecurityContext
`json:"securityContext,omitempty"`
+ // ImagePullSecrets pull an image from a private registry
+ ImagePullSecrets []corev1.LocalObjectReference
`json:"imagePullSecrets,omitempty"`
+ // Tolerations taints and tolerations work together to ensure that pods
are not scheduled onto inappropriate nodes
+ Tolerations []corev1.Toleration
`json:"tolerations,omitempty"`
+ // NodeSelector is the simplest recommended form of node selection
constraint.
+ NodeSelector map[string]string
`json:"nodeSelector,omitempty"`
+ // PodAnnotations you can use annotations to attach arbitrary
non-identifying metadata to objects.
+ PodAnnotations map[string]string
`json:"podAnnotations,omitempty"`
+ // PriorityClassName defines priority class's name
+ PriorityClassName string
`json:"priorityClassName,omitempty"`
Review comment:
It seems null checks are required for them, would define them as pointer
be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
